[pacman-dev] [PATCH] use -u when running fakeroot to preserve file owners

[Florian Pritz]

On 16.08.2011 16:48, Dave Reisner wrote:
> On Tue, Aug 16, 2011 at 09:23:06AM -0500, Dan McGee wrote:
>> On Tue, Aug 16, 2011 at 9:17 AM, Florian Pritz <bluewind at xinu.at> wrote:
>> > Running without -u breaks mkinitcpio-git PKGBUILD when running inside
>> > the git tree because files will be owned by root instead of the user.
>> > This makes git describe believe the tree has changed so it will consider
>> > it dirty while git describe outside fakeroot will consider it clean.
>> >
>> > References: http://www.spinics.net/lists/git/msg20973.html
>> >
>> > Signed-off-by: Florian Pritz <bluewind at xinu.at>
>> 
>> This sounds like it could cause all sorts of problems with
>> repackaging, namely things like `mkdir -p` usage in builds and having
>> directories owned by the complete wrong user. Have you tested this on
>> anything but your particular use case?
>> 
>> -Dan
>> 
> 
> Bare minimum, our .PKGINFO file isn't created by the current uid/gid.
> I'm not really a fan of this only because I don't know what else it
> implies.

Newly created files will default to the current user too, so don't merge
this.

Sorry for the noise.

-- 
Florian Pritz

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.archlinux.org/pipermail/pacman-dev/attachments/20110816/80e76d04/attachment.asc>