[pacman-dev] [PATCH v2] Skip rename() on NULL destfile in curl_download_internal()

Lukas Fleischer archlinux at cryptocrack.de
Thu Aug 18 02:00:22 EDT 2011


On Thu, Aug 18, 2011 at 07:50:06AM +0200, Lukas Fleischer wrote:
> Avoid a potential segfault that may occur if we use a temporary file and
> fail to build the destination file name from the effective URL.
> 
> Also, use the STRDUP macro instead of strdup() for the sake of better
> error handling on memory allocation failures.
> 
> Signed-off-by: Lukas Fleischer <archlinux at cryptocrack.de>
> ---
>  lib/libalpm/dload.c |   14 +++++++++-----
>  1 files changed, 9 insertions(+), 5 deletions(-)
> 

Crap, just noticed that Dan already pushed this one...


More information about the pacman-dev mailing list