[pacman-dev] [PATCH] Reset dload_interrupted early in curl_download_internal()

Lukas Fleischer archlinux at cryptocrack.de
Thu Aug 18 03:13:31 EDT 2011

On Wed, Aug 17, 2011 at 04:54:56PM +0200, Lukas Fleischer wrote:
> Avoid invoking unlink() with a NULL path if the URL isn't to a file and
> we fail to create a temporary file.
> Signed-off-by: Lukas Fleischer <archlinux at cryptocrack.de>
> ---
>  lib/libalpm/dload.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)

Note that this still isn't fixed with the latest refactoring (not sure
if 9f139550 was supposed to fix this). If we fail to create a temporary
file (around line 224), tempfile still points to NULL and the unlink()
invocation might result in a segfault.

More information about the pacman-dev mailing list