[pacman-dev] [PATCH 1/6] dload: move curl option setting to static func

Dan McGee dpmcgee at gmail.com
Fri Aug 19 10:58:52 EDT 2011

On Fri, Aug 19, 2011 at 9:55 AM, Dave Reisner <d at falconindy.com> wrote:
> On Fri, Aug 19, 2011 at 09:46:42AM -0500, Dan McGee wrote:
>> This is doing more than {subject} stated here. I'm not sure we should
>> be opening files and such in this method. Is that only so the final
>> setopt WRITEDATA call is moved here? I think it would make more sense
>> to leave that one behind and greatly simplify the argument list of
>> this method, rather than modifying stack variables of another
>> function.
> Fair point. Perhaps I went a bit overboard here, and I'm all for
> simplifying the param list a bit here. I've also considered globbing the
> tempfile, destfile, localf trifecta into a single struct (possibly
> attached to the payload), but I'm starting to run into variable name
> hell...

The payload is "private" anyway, so I don't think adding these fields
to the payload is necessarily a bad thing.


More information about the pacman-dev mailing list