[pacman-dev] [PATCH 1/4] pacman.c: Remove redundant strdup() in parsearg_global()

Lukas Fleischer archlinux at cryptocrack.de
Fri Aug 26 07:10:35 EDT 2011


config_set_arch() already calls strdup(). Remove strdup() from the
config_set_arch() invocation to avoid a memory leak.

Signed-off-by: Lukas Fleischer <archlinux at cryptocrack.de>
---
 src/pacman/pacman.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c
index 71413bd..d285a05 100644
--- a/src/pacman/pacman.c
+++ b/src/pacman/pacman.c
@@ -385,7 +385,7 @@ static int parsearg_global(int opt)
 	switch(opt) {
 		case OP_ARCH:
 			check_optarg();
-			config_set_arch(strdup(optarg));
+			config_set_arch(optarg);
 			break;
 		case OP_ASK:
 			check_optarg();
-- 
1.7.6.1



More information about the pacman-dev mailing list