[pacman-dev] [PATCH 5/6] contrib: add install rules for bash and zsh completion

[Dave Reisner]

On Sat, Dec 31, 2011 at 09:07:12PM -0600, Dan McGee wrote:
> Signed-off-by: Dan McGee <dan at archlinux.org>
> ---
> 
> If anyone has any exotic builds that this breaks in, let me know, but since we
> now install everything else we should probably do these too. This vastly
> simplifies the pacman-contrib PKGBUILD to say the least.
> 
>  contrib/Makefile.am |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/contrib/Makefile.am b/contrib/Makefile.am
> index 8751fd9..73494e8 100644
> --- a/contrib/Makefile.am
> +++ b/contrib/Makefile.am
> @@ -64,6 +64,12 @@ $(OURFILES): Makefile
>  
>  all-am: $(OURSCRIPTS) $(OURFILES)
>  
> +install-data-local:
> +	$(MKDIR_P) $(DESTDIR)$(sysconfdir)/bash_completion.d/
> +	$(INSTALL_DATA) bash_completion $(DESTDIR)$(sysconfdir)/bash_completion.d/pacman
> +	$(MKDIR_P) $(DESTDIR)$(datarootdir)/zsh/site-functions/
> +	$(INSTALL_DATA) zsh_completion $(DESTDIR)$(datarootdir)/zsh/site-functions/_pacman
> +

Don't we want an uninstall rule to match this? I recall having to add
them when I worked on the symlink voodoo for repo-add/remove and the
manpages.

>  bacman: $(srcdir)/bacman.in
>  bash_completion: $(srcdir)/bash_completion.in
>  paccache: $(srcdir)/paccache.in
> -- 
> 1.7.8.1
> 
>