[pacman-dev] [PATCH] Skip diskspace checking for symlinks and directories in all cases

Dan McGee dpmcgee at gmail.com
Tue Feb 8 01:44:15 EST 2011

On Monday, February 7, 2011, Allan McRae <allan at archlinux.org> wrote:
> On 08/02/11 13:35, Dan McGee wrote:
> We did this in some but not all cases, assuming the 0 value coming out of
> libarchive would not be a problem. However, this does not work for "fake"
> filesystems such as rpc_pipefs, which reports a free block and total block
> count of zero.
> Fix this by not ever counting symlinks or directories, and adding a note
> explaining that if we someday do count directories, their size needs to be
> attributed to the proper place.
> Signed-off-by: Dan McGee<dan at archlinux.org>
> Ack: Allan
> I see there is some nice tidy up in there too.

Sí. I forgot to include that in the commit message here, I'll do that
in the final thing. Most of it just results in fewer strlen and
snprintf calls.


More information about the pacman-dev mailing list