[pacman-dev] [PATCH] Ensure pkgbase/epoch are defined before doing anything

Dan McGee dan at archlinux.org
Wed Feb 9 08:56:46 EST 2011


When generating integrity sums, we could get some weird output before due to
epoch being uninitialized:

    /usr/bin/makepkg: line 234: [[: 2.6.37: syntax error: invalid arithmetic operator (error token is ".6.37")

Signed-off-by: Dan McGee <dan at archlinux.org>
---
 scripts/makepkg.sh.in |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
index 001178a..16dc0b8 100644
--- a/scripts/makepkg.sh.in
+++ b/scripts/makepkg.sh.in
@@ -1850,6 +1850,10 @@ else
 	source "$BUILDFILE"
 fi
 
+# set defaults if they weren't specified in buildfile
+pkgbase=${pkgbase:-${pkgname[0]}}
+epoch=${epoch:-0}
+
 if (( GENINTEG )); then
 	mkdir -p "$srcdir"
 	chmod a-s "$srcdir"
@@ -1859,9 +1863,6 @@ if (( GENINTEG )); then
 	exit 0 # $E_OK
 fi
 
-pkgbase=${pkgbase:-${pkgname[0]}}
-epoch=${epoch:-0}
-
 # check the PKGBUILD for some basic requirements
 check_sanity || exit 1
 
-- 
1.7.4



More information about the pacman-dev mailing list