[pacman-dev] [PATCH 2/3] makepkg: command line options for signing packages

[Denis A. Altoé Falqueto]

On Sat, Feb 19, 2011 at 12:51 PM, Allan McRae <allan at archlinux.org> wrote:
>> +       if [[ "${SIGNKEY}" ]]; then
>> +               if ! gpg --list-key "${SIGNKEY}" 1>/dev/null 2>&1; then
>> +                       error "$(gettext "The key ${SIGNKEY} doesn\'t
>> exist.")"
>> +                       exit 1
>> +               fi
>> +               SIGNWITHKEY="-u ${SIGNKEY}"
>> +       fi
>
> I wonder if this is checked too late.  I suppose with a package() function
> in a PKGBUILD, we can not rebuild by using "makepkg -R" but this still seems
> quite late to abort.

I've changed that test to happen just after check_sanity. Of course,
the signature is only tested if there is need to sign.

The new patch will go in a second.

-- 
A: Because it obfuscates the reading.
Q: Why is top posting so bad?

-------------------------------------------
Denis A. Altoe Falqueto
Linux user #524555
-------------------------------------------