[pacman-dev] [PATCH] WIP: check local DB version

Dan McGee dpmcgee at gmail.com
Mon Feb 28 11:34:38 EST 2011


On Sun, Feb 27, 2011 at 10:02 PM, Allan McRae <allan at archlinux.org> wrote:
> On 28/02/11 05:55, Dan McGee wrote:
>>
>> ---
>> Any feedback on this going in? One of the checklist items on my 3.5.0
>> release
>> list.
>>
>
> It works....  but notice the double print of the found file there:

Turns out to be because we called the db_version method once to check,
and then once in the error message. I refactored out the call so we
only make it once, but not a big deal as this method should have no
side effects. And obviously the printf() will also disappear in the
final version.

-Dan


More information about the pacman-dev mailing list