[pacman-dev] [PATCH 2/5] alpm/depcmp: new NODEPVERSION flag

[Xavier Chantry]

On Wed, Jan 19, 2011 at 7:57 PM, Dan McGee <dpmcgee at gmail.com> wrote:
> On Wed, Jan 19, 2011 at 11:13 AM, Florian Pritz <bluewind at xssn.at> wrote:
>> From: Xavier Chantry <chantry.xavier at gmail.com>
>>
>> This flag allows to disable version checking in dependency resolving
>> code.
>>
>> depcmp_tolerant respects the NODEPVERSION flag but we still keep the
>> original strict depcmp. The idea is to reduce the impact of the
>> NODEPVERSION flag by using it in fewer places.
>>
>> I replaced almost all depcmp calls by depcmp_tolerant in deps.c (except
>> in the public find_satisfier used by deptest / pacman -T), but I kept
>> depcmp in sync.c and conflict.c
>
> Seems mostly OK, but without digging in I don't really understand why
> some get changed and some do not.
>

Reading this again, the choice in find_satisfier probably does not
matter, since I doubt pacman -T specifies NODEPVERSION. And if it
could, well why not. So that one could be changed.

Otherwise, the problem is that we use depcmp both for dep checking and
conflict checking. We (Nagy, me) thought that nodepversion should only
appy to versioned dep, and not versioned conflict, which are separate.
But to be honest, I am not sure what's best.
IIRC it's Nagy who first mentioned he did not like that nodepversion
had an effect on all depcmp usage in the first version of the patch.