[pacman-dev] Fwd: PATCH: fixed set -e hack in makepkg
DJ Mills
danielmills1 at gmail.com
Thu Jul 7 22:13:07 EDT 2011
Instead of using || echo, which IMO is a silly hack, the only proper
way to check the
exit status of a command substitution is:
if ! var=$(command); then
commands
fi
This patch changes that in makepkg, and gets rid of a pre-optimization
that served
no purpose in in_array().
Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-got-rid-of-OPT_TEMP-hack-and-pointless-pre-optimizat.patch
Type: application/octet-stream
Size: 1350 bytes
Desc: not available
URL: <http://mailman.archlinux.org/pipermail/pacman-dev/attachments/20110707/b0d6a4f5/attachment.obj>
More information about the pacman-dev
mailing list