[pacman-dev] [PATCH 1/3] contrib/paclog-pkglist: fix script name in usage

[Dan McGee]

On Sun, Jul 17, 2011 at 12:15 PM, Dave Reisner <d at falconindy.com> wrote:
> Signed-off-by: Dave Reisner <dreisner at archlinux.org>
> ---
> Just an oversight when I renamed the script, as pointed out by Allan. Sadly,
> awk doesn't have an equivalent of ${0##*/} when excuted under a #!/bin/awk
> shebang (ARGV[0] will always show 'awk'), so we just hard code it.
>
>  contrib/paclog-pkglist |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/paclog-pkglist b/contrib/paclog-pkglist
> index 2c66e63..5948a0d 100755
> --- a/contrib/paclog-pkglist
> +++ b/contrib/paclog-pkglist
> @@ -19,8 +19,8 @@
>
>  BEGIN {
>   if (ARGC < 2) {
> -    printf "usage:   log2pkglist <pacman log>\n"
> -    printf "example: log2pkglist /var/log/pacman.log\n"
> +    printf "usage:   paclog-pkglist <pacman log>\n"
> +    printf "example: paclog-pkglist /var/log/pacman.log\n"
Something I did notice with this change is we didn't make this a *.in
script like every other one in this directory. If we did,
@localstatedir@/log/pacman.log would be useful here, just as we define
it in src/pacman/Makefile.am.

I'm also not sure of awk's command line foo, but it would be nice if
called without an argument we tried the default log location first
before erroring.

>     exit
>   }
>  }
> --
> 1.7.6
>
>
>