[pacman-dev] [PATCH 0/5] Make several struct types public

Dan McGee dan at archlinux.org
Thu Jun 16 13:01:32 EDT 2011


I was starting to hack a bit today on the files and backup lists we have in the
package to make them a bit more full featured:
 * files lists would have mode and size fields
 * backup entries would be split ahead of time, like deps and deltas

And realized I didn't want to add another 30 methods to the API just to follow
the current trend. So here is my patch series at reversing the status quo and
bringing a hint of sanity back into how we do things. There are now only four
opaque struct types left, and I don't see those changing anytime soon
(pmhandle_t, pmtrans_t, pmpkg_t, pmdb_t).

Feedback welcome.

Dan McGee (5):
  Make pmfileconflict_t type public
  Make struct pmconflict_t public
  Make pmdepend_t and pmdepmissing_t public
  Make pmdelta_t public
  Make pmgrp_t public

 lib/libalpm/alpm.h     |  162 ++++++++++++++++++++++++-----------------------
 lib/libalpm/conflict.c |   42 ------------
 lib/libalpm/conflict.h |   13 ----
 lib/libalpm/delta.c    |   43 ++-----------
 lib/libalpm/delta.h    |   15 -----
 lib/libalpm/deps.c     |   38 +-----------
 lib/libalpm/deps.h     |   15 -----
 lib/libalpm/group.c    |   12 ----
 lib/libalpm/group.h    |    7 --
 lib/libalpm/sync.c     |   10 +--
 src/pacman/query.c     |   15 ++---
 src/pacman/remove.c    |    8 +--
 src/pacman/sync.c      |   36 +++++------
 src/pacman/upgrade.c   |   28 +++-----
 src/util/pactree.c     |    8 +-
 src/util/testdb.c      |    9 +--
 16 files changed, 137 insertions(+), 324 deletions(-)

-- 
1.7.5.4



More information about the pacman-dev mailing list