[pacman-dev] [PATCH 0/3] repo-add desc/depends creation cleanup

Dave Reisner d at falconindy.com
Mon Jun 20 15:46:31 EDT 2011


This is basically what I referred to in my last patch about refactoring
desc/depends writing. I snuck in an extra winner (the first) to get rid
of the insane IFS tweaking and iteration of the .PKGINFO file with a for
loop.

Dan, I'm not sure if I can break this up any further, but I'm happy to refactor
if it would make you more comfortable. I know it's an insanely important code
path so I encourage you (and anyone else reading) to put on your nerd glasses
and nitpick this.

Dave Reisner (3):
  repo-add: bashify reading of .PKGINFO file
  repo-add: store multi-value fields as arrays
  repo-add: use format_entry for all desc/depends fields

 scripts/repo-add.sh.in |  105 +++++++++++++++++++++++------------------------
 1 files changed, 51 insertions(+), 54 deletions(-)

-- 
1.7.5.4



More information about the pacman-dev mailing list