[pacman-dev] [PATCH] makepkg: Added checks in check_software for distcc, ccache, strip and gzip

[Dan McGee]

On Wed, Jun 22, 2011 at 11:48 PM, Eric Bélanger <snowmaniscool at gmail.com> wrote:
> On Thu, Jun 23, 2011 at 12:02 AM, Eric Bélanger <snowmaniscool at gmail.com> wrote:
>> Signed-off-by: Eric Bélanger <snowmaniscool at gmail.com>
>> ---
>>
>> I thought about adding checks for the PKGEXT and SRCEXT compression utilities but I'm not sure as it might be overkill.  Anyway, they could always be added later on in another patch. BTW, I didn't test this patch as it seemed quite straightforward.
>>
>
> I forgot to mention it but this patch changes a bit how makepkg use
> distcc and ccache.  Currently, if the distcc or ccache options are
> used and they are not installed, makepkg simply doesn't enable the
> support and build the package like normal. However, with this patch,
> makepkg will aborts. To keep current behavoir, the error message for
> distcc and ccache will need to be replaced by a warning message.

This seems fine to me. Allan, thoughts? The only other thing I could
think of doing is fail if set in BUILDENV and not available, but don't
fail if specified in PKGBUILD options.

-Dan