[pacman-dev] [PATCH] makepkg: fix incorrect parenthesis in gettext call

[Allan McRae]

On 24/06/11 22:56, Dave Reisner wrote:
> On Fri, Jun 24, 2011 at 10:47:58PM +1000, Allan McRae wrote:
>> On 24/06/11 22:43, Allan McRae wrote:
>>> On 24/06/11 22:39, Dave Reisner wrote:
>>>> allan broke it in 4bdb868a.
>>>>
>>>> Signed-off-by: Dave Reisner<d at falconindy.com>
>>>> ---
>>>> scripts/makepkg.sh.in | 2 +-
>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
>>>> index e101a76..3d40bc1 100644
>>>> --- a/scripts/makepkg.sh.in
>>>> +++ b/scripts/makepkg.sh.in
>>>> @@ -2096,7 +2096,7 @@ if (( INFAKEROOT )); then
>>>> tidy_install
>>>> fi
>>>> else
>>>> - warning "$(gettext "Repackaging without the use of a %s function is
>>>> deprecated.")" "package()"
>>>> + warning "$(gettext "Repackaging without the use of a %s function is
>>>> deprecated." "package()")"
>>>> plain "$(gettext "File permissions may not be preserved.")"
>>>> fi
>>>> else
>>>
>>> You stuffed this up worse than I did....
>>>
>>
>> In fact...  what is wrong?
>>
>
> ==>  Validating source files with md5sums...
>      pacman.conf ... Passed
>      pacman.conf.x86_64 ... Passed
>      makepkg.conf ... Passed
> ==>  Extracting Sources...
> /usr/bin/makepkg: line 2325: unexpected EOF while looking for matching `)'
>
> Which traces back to this particular line. It's mismatched quoting,
> really.
>

Look at the line number and the patch sent to the list before your one...