[pacman-dev] [PATCH] lib/alpm: unlock the handle before freeing it

Dave Reisner d at falconindy.com
Thu Jun 30 00:34:25 EDT 2011

This avoids, probably among other things, leaving the lock file in place
after a SIGINT interrupts a sync DB update.

Fixes regression introduced in 4f8ae2b.

Signed-off-by: Dave Reisner <dreisner at archlinux.org>
Dan this seems to work (surviving a variety of -Sy and -Syu <pkg> testcases)
and pactest doesn't complain, but you know this portion of the code way
better than I do. Does this seem sane?

 lib/libalpm/alpm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/lib/libalpm/alpm.c b/lib/libalpm/alpm.c
index b0bbbe8..d35512b 100644
--- a/lib/libalpm/alpm.c
+++ b/lib/libalpm/alpm.c
@@ -117,6 +117,7 @@ int SYMEXPORT alpm_release(pmhandle_t *myhandle)
 		ret = -1;
+	_alpm_handle_unlock(myhandle);

More information about the pacman-dev mailing list