[pacman-dev] [PATCH] alpm: improve installing messages on warning/errors

[Dan McGee]

On Tue, Mar 1, 2011 at 5:11 PM, Xavier Chantry <chantry.xavier at gmail.com> wrote:
> On Mon, Feb 28, 2011 at 9:18 PM, Boris 'billiob' Faure
> <billiob at gmail.com> wrote:
>> ---
>>  lib/libalpm/add.c |    8 ++++----
>>  1 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/lib/libalpm/add.c b/lib/libalpm/add.c
>> index 702b12e..db5ee74 100644
>> --- a/lib/libalpm/add.c
>> +++ b/lib/libalpm/add.c
>> @@ -401,14 +401,14 @@ static int extract_single_file(struct archive *archive,
>>                                                " new one with .pacnew ending\n");
>>                                snprintf(newpath, PATH_MAX, "%s.pacnew", filename);
>>                                if(rename(checkfile, newpath)) {
>> -                                       _alpm_log(PM_LOG_ERROR, _("could not install %s as %s (%s)\n"),
>> +                                       _alpm_log(PM_LOG_ERROR, _("could not install new %s as %s (%s)\n"),
>>                                                        filename, newpath, strerror(errno));
>> -                                       alpm_logaction("error: could not install %s as %s (%s)\n",
>> +                                       alpm_logaction("error: could not install new %s as %s (%s)\n",
>>                                                        filename, newpath, strerror(errno));
>>                                } else {
>> -                                       _alpm_log(PM_LOG_WARNING, _("%s installed as %s\n"),
>> +                                       _alpm_log(PM_LOG_WARNING, _("new %s installed as %s\n"),
>>                                                        filename, newpath);
>> -                                       alpm_logaction("warning: %s installed as %s\n",
>> +                                       alpm_logaction("warning: new %s installed as %s\n",
>>                                                        filename, newpath);
>>                                }
>>                        }
>
> We both aren't native english speakers, but Dan is and here's what he
> had to say :
>
> Dan: sounds awful to me in english
> "%s from new package installed as" or something seems better

Whoops, yeah, forgot to respond.

The "what is new" bit was confusing in the changed message, as it was
used as an adjective on the old filename.

-Dan