[pacman-dev] [PATCH 1/3] Add --with-bsdtar-bin configure option

Dan McGee dpmcgee at gmail.com
Thu Mar 24 02:24:27 EDT 2011


On Sat, Nov 6, 2010 at 4:26 PM, Nezmer <git at nezmer.info> wrote:
> On Thu, Oct 14, 2010 at 11:57:00PM +0300, Nezmer wrote:
>> On Thu, Oct 14, 2010 at 04:56:17PM +0300, Nezmer wrote:
>> > This will enable us to use a custom name and/or location of bsdtar
>> > binary in scripts.
>> >
>> > Signed-off-by: Nezmer <git at nezmer.info>
>> > ---
>> >  configure.ac                  |    6 ++++++
>> >  contrib/Makefile.am           |    1 +
>> >  contrib/bacman.in             |    4 ++--
>> >  contrib/pacscripts.in         |    4 ++--
>> >  scripts/Makefile.am           |    1 +
>> >  scripts/makepkg.sh.in         |   12 ++++++------
>> >  scripts/pacman-optimize.sh.in |    4 ++--
>> >  scripts/pkgdelta.sh.in        |    2 +-
>> >  scripts/repo-add.sh.in        |   14 +++++++-------
>> >  9 files changed, 28 insertions(+), 20 deletions(-)
>> >
>> > --
>> > 1.7.3.1
>> >
>>
>> Any thoughts on this one?
>>
>
> Is this rejected?

Old, sorry about this. I'm going to -1 this one- it prevents someone
from later changing the path (like installing a newer version in
/usr/local, for instance). We could be smarter in some of our main
scripts and bail early if bsdtar doesn't exist, like the gettext
check.

-Dan


More information about the pacman-dev mailing list