[pacman-dev] [PATCH] alpm/handle.c: ensure handle is not NULL before proceeding

Dan McGee dpmcgee at gmail.com
Mon Mar 28 16:46:03 EDT 2011

On Mon, Mar 28, 2011 at 2:47 PM, Rémy Oudompheng
<remyoudompheng at gmail.com> wrote:
> Many alpm_option_get/set_*() functions already check this
> and set pm_errno to the right value, but not all, so
> this improves consistency.
> Signed-off-by: Rémy Oudompheng <remy at archlinux.org>
> ---
> +#define RET_ERR_VOID(err) do { pm_errno = (err); \
> +       _alpm_log(PM_LOG_DEBUG, "returning error %d from %s : %s\n", err, __func__, alpm_strerrorlast()); \
> +       return; } while(0)
> +
>  #define RET_ERR(err, ret) do { pm_errno = (err); \
>        _alpm_log(PM_LOG_DEBUG, "returning error %d from %s : %s\n", err, __func__, alpm_strerrorlast()); \
>        return(ret); } while(0)
> --

I can tell from this bit I've snipped you are patching maint, and not
master, but I did not know this right away. It helps all of us greatly
when reviewing if we know where you intend the patch to land- indicate
that below the --- lines in your patch submission, right before the

Otherwise, +1 from me given a bit more testing especially if we are
going to maint with this.


More information about the pacman-dev mailing list