[pacman-dev] [PATCH 4/4] Allow VerifySig to act as a default verification in [options]

[Dan McGee]

On Mon, Mar 28, 2011 at 2:53 PM, Dave Reisner <d at falconindy.com> wrote:
> On Mon, Mar 28, 2011 at 09:34:57PM +0200, Rémy Oudompheng wrote:
>> On Mon 28 March 2011 at 15:15 -0400, Dave Reisner wrote:
>> > +/* GPG signature verification option */
>> > +typedef enum _pgp_verify_t {
>> > +   PM_PGP_VERIFY_UNKNOWN,
>> > +   PM_PGP_VERIFY_ALWAYS,
>> > +   PM_PGP_VERIFY_OPTIONAL,
>> > +   PM_PGP_VERIFY_NEVER
>> > +} pgp_verify_t;
>> > +
>> > +int alpm_db_set_pgp_verify(pmdb_t *db, pgp_verify_t verify);
>>
>> Why is this enum name not prefixed by "pm" ?
>>
>> Why isn't alpm_db_set_pgp_verify with the other database functions
>> (e.g. alpm_db_setserver()) ?
>>
>
> Dan's naming, not mine. Adding the pm prefix makes sense here. I added
> it with the signature related functions since it's related to
> signatures and not strictly databases (think of pacman -U).

I've started to call some of this out. As long as we don't release in
this awesome condition, I'm fine with bringing some of this work in so
we can at least keep the ball rollling, but feel free to add any other
concerns here: https://wiki.archlinux.org/index.php/User:Allan/Package_Signing#Other_Issues

-Dan