[pacman-dev] [PATCH] makepkg: trim trailing space from whitespace sensitive vars

[Allan McRae]

On 18/11/11 12:28, Dan McGee wrote:
> On Thu, Nov 17, 2011 at 1:09 PM, Dave Reisner<d at falconindy.com>  wrote:
>> Declarations such as:
>>
>> pkgver=2.11    # foo
>>
>> will work, but trimming off the comment (without trimming the trailing
>> whitespace) will result in an incorrect validation error. Bash automatically
>> trims this trailing whitespace and does the right thing under the covers,
>> so we should honor this as well.
>>
>> NB: We don't need to worry about leading whitespace because it will cause a
>> syntax error (when unquoted), or fail validation (when quoted).
>>
>> Signed-off-by: Dave Reisner<dreisner at archlinux.org>
>> ---
>> Too late to squeeze this into maint?
> Nope, no string changes. Normally a test and signoff from Allan would
> go a long way to boost my confidence in last-minute changes, but he is
> gone, right? Anyone else want to give this patch a spin with PKGBUILDs
> testing the above cases?
>

Fix epoch too and I will give this a signoff...

Allan