[pacman-dev] [PATCH 2/2] makepkg: Allow install/changelog decls to be arrays
d at falconindy.com
Sun Oct 9 23:57:11 EDT 2011
On Mon, Oct 10, 2011 at 01:53:38PM +1000, Allan McRae wrote:
> On 10/10/11 13:35, Dave Reisner wrote:
> >This doesn't actually change the treatment of install and changelog
> >varaibles, but it allows valid bash syntax to get by our parsing of
> >these variables.
> >Fixes FS#25827.
> >Signed-off-by: Dave Reisner<dreisner at archlinux.org>
> >This is getting pretty ugly... I'm still 50/50 on whether or not we should do
> >this. I will point out that if we choose not to merge this, there's a dozen or
> >so packages in extra/community that need to be fixed:
> >$ grep -lE '^(install|changelog)=\(' /var/abs/*/*/PKGBUILD
> >And just because I'm getting a little paranoid about making changes this close
> >to release, here's the test rig I used to proof this patch:
> >Allan, thoughts?
> I will give this an ack. I lean ever so slightly to the side that
> if bash accepts that syntax then so should we. So given this is a
> fairly small fix, I see no point in not including it.
> I added a couple more cases to your tests (involving files with
> spaces...) and all seems good to me.
Ok -- pushing a slightly revised version to my working branch then which
uses -e 's/ex/pr/' -e 's/ex/pr/' because I'm suddenly reminded that
combining expressions isn't supported with BSD sed.
More information about the pacman-dev