[pacman-dev] [PATCH] pactree: Make error message smarter in register_syncs()

Lukas Fleischer archlinux at cryptocrack.de
Mon Oct 10 09:22:52 EDT 2011


Our error message used to be very unclear when the configuration file
could not be found:

    $ ./pactree -lsr gtk
    error: failed to register sync DBs

Instead, display an accurate message and include the file name:

    $ ./pactree -lsr gtk
    error: config file /usr/local/etc/pacman.conf could not be read

Also, move the error message inside register_syncs() to allow for
differentiating between different errors that might require a handler in
the future.

Signed-off-by: Lukas Fleischer <archlinux at cryptocrack.de>
---
 src/util/pactree.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/util/pactree.c b/src/util/pactree.c
index 5e98f79..997ba46 100644
--- a/src/util/pactree.c
+++ b/src/util/pactree.c
@@ -162,6 +162,7 @@ static int register_syncs(void) {
 
 	fp = fopen(configfile, "r");
 	if(!fp) {
+		fprintf(stderr, "error: config file %s could not be read\n", configfile);
 		return 1;
 	}
 
@@ -463,7 +464,6 @@ int main(int argc, char *argv[])
 
 	if(searchsyncs) {
 		if(register_syncs() != 0) {
-			fprintf(stderr, "error: failed to register sync DBs\n");
 			ret = 1;
 			goto finish;
 		}
-- 
1.7.7



More information about the pacman-dev mailing list