[pacman-dev] [PATCH 1/2] Show an error message on failed remote key lookup

Dan McGee dan at archlinux.org
Mon Oct 17 10:44:07 EDT 2011

The absolutely terrible part about this is the failure on GPGME's part
to distinguish between "key not found" and "keyserver timeout". Instead,
it returns the same silly GPG_ERR_EOF in both cases (why isn't
GPG_ERR_TIMEOUT being used?), leaving us helpless to tell them apart.

Spit out a generic enough error message that covers both cases;
unfortunately we can't provide much guidance to the user because we
aren't sure what actually happened.

Signed-off-by: Dan McGee <dan at archlinux.org>
 lib/libalpm/signing.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/libalpm/signing.c b/lib/libalpm/signing.c
index bdaa83a..92f34b5 100644
--- a/lib/libalpm/signing.c
+++ b/lib/libalpm/signing.c
@@ -797,8 +797,8 @@ int _alpm_process_siglist(alpm_handle_t *handle, const char *identifier,
 									fetch_key.fingerprint, fetch_key.uid);
 					} else {
-						_alpm_log(handle, ALPM_LOG_DEBUG,
-								"key could not be looked up remotely\n");
+						_alpm_log(handle, ALPM_LOG_ERROR,
+								_("key \"%s\" could not be looked up remotely\n"), name);

More information about the pacman-dev mailing list