[pacman-dev] make install fails to replace repo-add

[Dan McGee]

On Tue, Sep 13, 2011 at 6:54 AM, Sergej Pupykin <ml at sergej.pp.ru> wrote:
>
> Hi,
>
> I have got following from "make install DESTDIR=..."
>
> cd /home/sergej/extent/pacman.git/PKG/usr/bin && \
>        ( ln -s repo-add repo-elephant || \
>        ln repo-add repo-elephant || \
>        cp repo-add repo-elephant )
> ln: failed to create symbolic link `repo-elephant': File exists
> ln: failed to create hard link `repo-elephant': File exists
> cp: `repo-add' and `repo-elephant' are the same file
> make[4]: *** [install-data-hook] Error 1
> make[4]: Leaving directory `/home2/home/sergej/pacman.git/scripts'
> make[3]: *** [install-data-am] Error 2
> make[3]: Leaving directory `/home2/home/sergej/pacman.git/scripts'
> make[2]: *** [install-am] Error 2
> make[2]: Leaving directory `/home2/home/sergej/pacman.git/scripts'
> make[1]: *** [install-recursive] Error 1
> make[1]: Leaving directory `/home2/home/sergej/pacman.git/scripts'
> make: *** [install-recursive] Error 1
>
> Problem probably here:
>
> scripts/Makefile.am
>
> install-data-hook:
>        cd $(DESTDIR)$(bindir) && \
>                ( $(LN_S) repo-add repo-elephant || \
>                ln repo-add repo-elephant || \
>                cp repo-add repo-elephant )
>        cd $(DESTDIR)$(bindir) && \
>                ( $(LN_S) repo-add repo-remove || \
>                ln repo-add repo-remove || \
>                cp repo-add repo-remove )

This probably wasn't tested with existing files in the way since none
of us have done that. Dave, I think we just need to add a `rm -f
<foobar>` call in this command?

-Dan