[pacman-dev] [PATCH] Revert "libalpm: compare pkgname with strcoll"

Dan McGee dan at archlinux.org
Tue Sep 27 21:30:55 EDT 2011

This commit was made with the intent of displaying "correctly" sorted
package lists to users. Here are some reasons I think this is incorrect:

* It is done in the wrong place. If a frontend application wants to show
  a different order of packages dependent on locale, it should do that
  on its own.
* Even if one wants a locale-specific order, almost all package names
  are all ASCII and language agnostic, so this different comparison
  makes little sense and may serve only to confuse people.
* _alpm_pkg_cmp was unlike any other comparator function. None of the
  rest had any dependency on anything but the content of the structs
  being compared (e.g., they only used strcmp() or other basic
  comparison operators).

This reverts commit 3e4d2c3aa65416487939148828afb385de2ee146.

Signed-off-by: Dan McGee <dan at archlinux.org>
 lib/libalpm/package.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/libalpm/package.c b/lib/libalpm/package.c
index 11bf01a..a5ff238 100644
--- a/lib/libalpm/package.c
+++ b/lib/libalpm/package.c
@@ -641,7 +641,7 @@ int _alpm_pkg_cmp(const void *p1, const void *p2)
 	const alpm_pkg_t *pkg1 = p1;
 	const alpm_pkg_t *pkg2 = p2;
-	return strcoll(pkg1->name, pkg2->name);
+	return strcmp(pkg1->name, pkg2->name);
 /* Test for existence of a package in a alpm_list_t*

More information about the pacman-dev mailing list