[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.0.0rc2-32-g6f3a657

Wed Sep 28 11:20:13 EDT 2011

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The official pacman repository".

The branch, master has been updated
       via  6f3a657f66b9c766b5fa6c51c26283d3547f5169 (commit)
       via  bcc6a5d72df3cb3ee9f3d2347526c3dc03d5f55a (commit)
       via  1b8bb7c1cd81c1f8f0dcffc952cd464b6a436f06 (commit)
       via  f682cbd43355daa7b13389d74e0ffea0370ba89b (commit)
       via  7edeb276b63efeea7e8f266dfee792e2709ba412 (commit)
       via  bd83c8e7562a2d6794d4322845c23cc21985979a (commit)
       via  40a264478e65c652f863b3e43b0fc8aa10f0bd19 (commit)
       via  6e081a0c57f0f6f14428f7cb78bb22f6848fe4af (commit)
       via  98e0371ae38d748fb04cec4759addb54e3a618ea (commit)
       via  f66f9f11cd010a05efe28d0607abbf29ff8dffa5 (commit)
       via  ea3c47825ea6a8cfd0e0d63fd7da0120fcacabc8 (commit)
       via  69962184bb3cc313f744de6553ef31b4eb256a01 (commit)
       via  d8fab9b4415b2382c9b5d92f6d0d40074ab65f30 (commit)
       via  bf56fb6eb82b732900c32cbf375f7910ac479d98 (commit)
       via  619c3629ca61cea2c182fcb0197f9b84ba4209c3 (commit)
      from  e70d540501d718583a8e4b91ca5989af3f3db77d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6f3a657f66b9c766b5fa6c51c26283d3547f5169
Author: Dan McGee <dan at archlinux.org>
Date:   Wed Sep 28 04:46:22 2011 -0500

    Always show download size if -w/--downloadonly was provided

    The prompt can be rather confusing otherwise when all files have already
    been downloaded, but there is not a single total size listed.

    Signed-off-by: Dan McGee <dan at archlinux.org>

commit bcc6a5d72df3cb3ee9f3d2347526c3dc03d5f55a
Author: Dan McGee <dan at archlinux.org>
Date:   Mon Sep 12 21:25:58 2011 -0400

    Table format creation code cleanup

    Better scoping of variables for the most part, and ensure we are using
    string_length() and not strlen() as appropriate. Also refactor the
    longest cell code to call string_length() a lot less; by simply using an
    array of max sizes we don't have to recompute values nearly as much.

    Signed-off-by: Dan McGee <dan at archlinux.org>

commit 1b8bb7c1cd81c1f8f0dcffc952cd464b6a436f06
Author: Dan McGee <dan at archlinux.org>
Date:   Wed Sep 28 09:44:15 2011 -0500

    Use unsigned types for indent width and column count

    For getcols(), the functions we call return a value of type 'unsigned
    short', so it makes sense for us to do the same.

    string_length() is meant to behave like strlen(), so it should return
    type size_t. This exposes other functions such as indentprint() which
    should also be using signed return types.

    Signed-off-by: Dan McGee <dan at archlinux.org>

commit f682cbd43355daa7b13389d74e0ffea0370ba89b
Author: Dan McGee <dan at archlinux.org>
Date:   Mon Sep 12 20:44:15 2011 -0400

    Show download sizes when using -S/--sync

    We now label the old 'Size' column as 'Net Change' to reflect the
    reality of what we are looking at. Sync operations now get an additional
    'Download Size' column.

    Signed-off-by: Dan McGee <dan at archlinux.org>

commit 7edeb276b63efeea7e8f266dfee792e2709ba412
Author: Dan McGee <dan at archlinux.org>
Date:   Fri Jul 29 15:35:59 2011 -0500

    Keep track of explicitly added and removed packages

    This allows us to sort the output list by showing all pulled
    dependencies first, followed by the explicitly specified targets.

    Signed-off-by: Dan McGee <dan at archlinux.org>

commit bd83c8e7562a2d6794d4322845c23cc21985979a
Author: Dan McGee <dan at archlinux.org>
Date:   Fri Jul 22 12:01:58 2011 -0500

    Combine add and removal package list display

    There was no real reason for these to be done separately.

    Signed-off-by: Dan McGee <dan at archlinux.org>

commit 40a264478e65c652f863b3e43b0fc8aa10f0bd19
Author: Dan McGee <dan at archlinux.org>
Date:   Wed Sep 28 01:53:43 2011 -0500

    Track unresolvable transaction packages

    Rather than free them right away, keep the list on the transaction as
    we already do with add and remove lists. This is necessary because we
    may be manipulating pointers the frontend needs to refer to packages,
    and we are breaking our contract as stated in the alpm_add_pkg()
    documentation of only freeing packages at the end of a transaction.

    This fixes an issue found when refactoring the package list display
    code.

    Signed-off-by: Dan McGee <dan at archlinux.org>

commit 6e081a0c57f0f6f14428f7cb78bb22f6848fe4af
Author: Dan McGee <dan at archlinux.org>
Date:   Wed Sep 28 04:45:30 2011 -0500

    Move pacsave path construction code off the stack

    This is definitely not in the normal hot path, so we can afford to do
    some temporary heap allocation here.

    Signed-off-by: Dan McGee <dan at archlinux.org>

commit 98e0371ae38d748fb04cec4759addb54e3a618ea
Author: Dan McGee <dan at archlinux.org>
Date:   Wed Sep 28 04:06:43 2011 -0500

    Use the full buffer when computing md5/sha256 sums

    No wonder these were slower than expected. We were only reading 4
    (32-bit) or 8 (64-bit) bytes at a time and feeding it to the hash
    functions. Define a buffer size constant and use it correctly so we feed
    8K at a time into the hashing algorithm.

    This cut one larger `-Sw --noconfirm` operation, with nothing to
    actually download so only timing integrity, from 3.3s to 1.7s.

    This has been broken since the original commit eba521913d6 introducing
    OpenSSL usage for crypto hash functions. Boy do I feel stupid.

    Signed-off-by: Dan McGee <dan at archlinux.org>

commit f66f9f11cd010a05efe28d0607abbf29ff8dffa5
Author: Dan McGee <dan at archlinux.org>
Date:   Wed Sep 28 02:56:36 2011 -0500

    Fix memory leak in download payload->remote_name

    In the sync code, we explicitly allocated a string for this field, while
    in the dload code itself it was filled in with a pointer to another
    string. This led to a memory leak in the sync download case.

    Make remote_name non-const and always explicitly allocate it. This patch
    ensures this as well as uses malloc + snprintf (rather than calloc) in
    several codepaths, and eliminates the only use of PATH_MAX in the
    download code.

    Signed-off-by: Dan McGee <dan at archlinux.org>

commit ea3c47825ea6a8cfd0e0d63fd7da0120fcacabc8
Author: Dan McGee <dan at archlinux.org>
Date:   Tue Sep 27 20:24:04 2011 -0500

    Revert "libalpm: compare pkgname with strcoll"

    This commit was made with the intent of displaying "correctly" sorted
    package lists to users. Here are some reasons I think this is incorrect:

    * It is done in the wrong place. If a frontend application wants to show
      a different order of packages dependent on locale, it should do that
      on its own.
    * Even if one wants a locale-specific order, almost all package names
      are all ASCII and language agnostic, so this different comparison
      makes little sense and may serve only to confuse people.
    * _alpm_pkg_cmp was unlike any other comparator function. None of the
      rest had any dependency on anything but the content of the structs
      being compared (e.g., they only used strcmp() or other basic
      comparison operators).

    This reverts commit 3e4d2c3aa65416487939148828afb385de2ee146.

    Signed-off-by: Dan McGee <dan at archlinux.org>

commit 69962184bb3cc313f744de6553ef31b4eb256a01
Author: Dan McGee <dan at archlinux.org>
Date:   Tue Sep 27 17:47:40 2011 -0500

    _alpm_splitdep: use malloc instead of calloc

    There was only one simple to handle case where we left a field
    uninitialized; set it to NULL and use malloc() instead.

    Signed-off-by: Dan McGee <dan at archlinux.org>

commit d8fab9b4415b2382c9b5d92f6d0d40074ab65f30
Author: Dan McGee <dan at archlinux.org>
Date:   Tue Sep 27 17:36:31 2011 -0500

    be_sync: fetch only entry mode, not full stat struct

    This saves a lot of unnecessary work since we don't need any of the
    other fields in the stat struct.

    Signed-off-by: Dan McGee <dan at archlinux.org>

commit bf56fb6eb82b732900c32cbf375f7910ac479d98
Author: Dan McGee <dan at archlinux.org>
Date:   Tue Sep 27 16:14:17 2011 -0500

    alpm_list: use malloc instead of calloc

    In every case we were calling calloc, the struct we allocated (or the
    memory to be used) is fully specified later in the method.

    For alpm_list_t allocations, we always set all of data, next, and prev.

    For list copying and transforming to an array, we always copy the entire
    data element, so no need to zero it first.

    Signed-off-by: Dan McGee <dan at archlinux.org>

commit 619c3629ca61cea2c182fcb0197f9b84ba4209c3
Author: Dave Reisner <dreisner at archlinux.org>
Date:   Tue Sep 27 11:27:54 2011 -0400

    makepkg: ensure '-' is last in a character glob

    If '-' isn't the last item, it's interpreted as a range and not
    literally, causing problematic behavior in parsing optdepends.

    Signed-off-by: Dave Reisner <dreisner at archlinux.org>

-----------------------------------------------------------------------

Summary of changes:
 lib/libalpm/alpm_list.c |    8 +-
 lib/libalpm/be_sync.c   |    7 +-
 lib/libalpm/deps.c      |    8 +-
 lib/libalpm/dload.c     |   26 +++--
 lib/libalpm/dload.h     |    2 +-
 lib/libalpm/package.c   |    2 +-
 lib/libalpm/pkghash.c   |    8 +-
 lib/libalpm/remove.c    |    8 +-
 lib/libalpm/sync.c      |   21 ++--
 lib/libalpm/trans.c     |    3 +
 lib/libalpm/trans.h     |    5 +-
 lib/libalpm/util.c      |   10 +-
 scripts/makepkg.sh.in   |    3 +-
 src/pacman/callback.c   |    4 +-
 src/pacman/conf.c       |    4 +-
 src/pacman/conf.h       |    3 +
 src/pacman/remove.c     |   12 +-
 src/pacman/sync.c       |    6 +-
 src/pacman/upgrade.c    |    1 +
 src/pacman/util.c       |  284 ++++++++++++++++++++++++++++++-----------------
 src/pacman/util.h       |   12 ++-
 21 files changed, 277 insertions(+), 160 deletions(-)

hooks/post-receive
-- 
The official pacman repository