[pacman-dev] [PATCH] fixed erroneous memory access to newurl in alpm_db_remove_server

[Allan McRae]

On 08/08/12 18:00, Barbu Paul - Gheorghe wrote:
> On 07/31/2012 09:01 AM, Barbu Paul - Gheorghe wrote:
>>> Instead of creating a new variable, why not just free(newurl) here and
>>> keep the return?
>>
>> The reason behind this is that I didn't want to have two calls to
>> free(newurl)
>> for each execution branch (the same applies for the return statement).
>>
>> Should I modify it with two calls or should I leave it this way and
>> just fix the
>> coding standard violation that you mentioned above?
>>
>> Have a nice day!
>>
> 
> What should I do?
> Did anyone looked into my argument yet?
> 

@Dan: what is your preference here?

Allan