[pacman-dev] [PATCH] [makepkg] Print out full version on pkgver update

[Allan McRae]

On 14/12/12 01:56, William Giokas wrote:
> When building sources with a pkgver function, makepkg will print out the
> original version before pkgver() is run, claiming that that is the
> package that will be built. This patch simply re-prints the output
> later, after pkgver() has been run so people can see which package they
> are actually building.
> 
> Signed-off-by: William Giokas <1007380 at gmail.com>
> ---

Ack.

FYI, we usually just put "makepkg: " at the start of the commit subject
to signify makepkg patches.

>  scripts/makepkg.sh.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index a5ac59a..f9a4044 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -700,6 +700,8 @@ update_pkgver() {
>  			@SEDINPLACE@ "s/^pkgver=[^ ]*/pkgver=$newpkgver/" "$BUILDFILE"
>  			@SEDINPLACE@ "s/^pkgrel=[^ ]*/pkgrel=1/" "$BUILDFILE"
>  			source "$BUILDFILE"
> +			local fullver=$(get_full_version)
> +			msg "$(gettext "Updated version: %s")" "$pkgbase $fullver"
>  		else
>  			warning "$(gettext "%s is not writeable -- pkgver will not be updated")" \
>  					"$BUILDFILE"
>