[pacman-dev] [PATCH] Remove a pm_errno = 0 line

Nagy Gabor ngaba at bibl.u-szeged.hu
Wed Feb 8 23:23:20 EST 2012

> > In the download code a successful package-download could reset the previously
> > set pm_errno to 0, which is unwanted.
> > 
> > Signed-off-by: Nagy Gabor <ngaba at bibl.u-szeged.hu>
> This patch needs testing. Btw, I can see more pm_errno = 0 line in the
> code, which is not a good practice...
> NG

I revoke this patch. That pm_errno = 0 line is there for indicating the
successful download of the same file from an other mirror. As a side
effect, every successful download clears the "pm_errno history". This
is again a design limitation (this should be handled in sync.c). :-(

More information about the pacman-dev mailing list