[pacman-dev] [PATCH] Do not dereference symlinks when calculating size

Allan McRae allan at archlinux.org
Fri Feb 24 19:05:58 EST 2012


On 25/02/12 01:59, Dan McGee wrote:
> On Fri, Feb 24, 2012 at 6:04 AM, Allan McRae <allan at archlinux.org> wrote:
>> Passing the "-L" flag to stat means we get the size of the file
>> being pointed to for symlinks instead of the size of the symlink.
>>
>> Signed-off-by: Allan McRae <allan at archlinux.org>
> 
> NACK. You're reverting this commit. This is what we get for trying to
> repurpose SIZECMD for use in makepkg, it looks like you need a second
> command.
> 
> commit 20aa17c276c35e08c7a8e2aa20410b99a20f8129
> Author: Dan McGee <dan at archlinux.org>
> Date:   Wed Sep 23 19:11:34 2009 -0500
> 
>     repo-add: make sure we get size of target file
> 
>     If the package we were adding was a symlink, we stuck the symlink size in
>     the database rather than the size of the file it referred to. Whoops!
> 
>     Signed-off-by: Dan McGee <dan at archlinux.org>
> 

OK, did not seed this....  Will send a fixed on later.

Allan



More information about the pacman-dev mailing list