[pacman-dev] [PATCH] be_package.c: fix compiler warning

[Dan McGee]

On Sun, Jan 1, 2012 at 10:32 PM, Allan McRae <allan at archlinux.org> wrote:
> be_package.c: In function 'parse_descfile':
> be_package.c:181:28: error: comparison between signed and unsigned
> integer expressions [-Werror=sign-compare]
>
> ptr - key + 2 is guaranteed to be > 0 so we can cast to size_t
>
> Signed-off-by: Allan McRae <allan at archlinux.org>
> ---
>
> I did reply to the patch email about this...
100% my fault on missing this change; sorry 'bout that.

>  lib/libalpm/be_package.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/libalpm/be_package.c b/lib/libalpm/be_package.c
> index c602996..fccbb10 100644
> --- a/lib/libalpm/be_package.c
> +++ b/lib/libalpm/be_package.c
> @@ -178,7 +178,7 @@ static int parse_descfile(alpm_handle_t *handle, struct archive *a, alpm_pkg_t *
>                /* line is always in this format: "key = value"
>                 * we can be sure the " = " exists, so look for that */
>                ptr = memchr(key, ' ', len);
> -               if(!ptr || ptr - key + 2 > len || memcmp(ptr, " = ", 3) != 0) {
> +               if(!ptr || (size_t)(ptr - key + 2) > len || memcmp(ptr, " = ", 3) != 0) {
>                        _alpm_log(handle, ALPM_LOG_DEBUG,
>                                        "%s: syntax error in description file line %d\n",
>                                        newpkg->name ? newpkg->name : "error", linenum);
> --
> 1.7.8.1
>
>