[pacman-dev] [PATCH] Only create string when needed (libalpm)

jjacky i.am.jack.mail at gmail.com
Mon Jan 9 14:21:07 EST 2012


The entry's name is only used when not "." or ".." so only
print the string then.

Signed-off-by: Olivier Brunel <i.am.jack.mail at gmail.com>
---
  lib/libalpm/util.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/libalpm/util.c b/lib/libalpm/util.c
index e2cbd8c..4245039 100644
--- a/lib/libalpm/util.c
+++ b/lib/libalpm/util.c
@@ -427,8 +427,8 @@ int _alpm_rmrf(const char *path)
                         }
                         for(dp = readdir(dirp); dp != NULL; dp = 
readdir(dirp)) {
                                 if(dp->d_ino) {
-                                       sprintf(name, "%s/%s", path, 
dp->d_name);
                                         if(strcmp(dp->d_name, "..") != 
0 && strcmp(dp->d_name, ".") != 0) {
+                                               sprintf(name, "%s/%s", 
path, dp->d_name);
                                                 errflag += 
_alpm_rmrf(name);
                                         }
                                 }
-- 
1.7.8.3


More information about the pacman-dev mailing list