[pacman-dev] [PATCH 2/2] pacman-key: reduce verbosity of --populate

[Allan McRae]

On 19/06/12 00:46, Pierre Schmitz wrote:
> Do not bother the user with gpg's verbose output.
> 
> Signed-off-by: Pierre Schmitz <pierre at archlinux.de>
> ---
>  scripts/pacman-key.sh.in |    4 ++--
>  1 Datei geändert, 2 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-)
> 
> diff --git a/scripts/pacman-key.sh.in b/scripts/pacman-key.sh.in
> index e5b6021..df1ff9e 100644
> --- a/scripts/pacman-key.sh.in
> +++ b/scripts/pacman-key.sh.in
> @@ -277,7 +277,7 @@ populate_keyring() {
>  	# Add keys from requested keyrings
>  	for keyring in "${KEYRINGIDS[@]}"; do
>  		msg "$(gettext "Appending keys from %s.gpg...")" "$keyring"
> -		"${GPG_PACMAN[@]}" --import "${KEYRING_IMPORT_DIR}/${keyring}.gpg"
> +		"${GPG_PACMAN[@]}" --quiet --import "${KEYRING_IMPORT_DIR}/${keyring}.gpg"

Ack.

>  	done
>  
>  	# Read the trusted key IDs to an array. Because this is an ownertrust
> @@ -307,7 +307,7 @@ populate_keyring() {
>  		msg "$(gettext "Importing owner trust values...")"
>  		for keyring in "${KEYRINGIDS[@]}"; do
>  			if [[ -s "${KEYRING_IMPORT_DIR}/${keyring}-trusted" ]]; then
> -				"${GPG_PACMAN[@]}" --import-ownertrust "${KEYRING_IMPORT_DIR}/${keyring}-trusted"
> +				"${GPG_PACMAN[@]}" --import-ownertrust "${KEYRING_IMPORT_DIR}/${keyring}-trusted" 2>/dev/null

Ugh...  I hate how mundane stuff is printed to stderr here.  Is there
anything that can possible go wrong during this step that would actually
require us to see output on stderr?