[pacman-dev] [PATCH 2/2] pacman-key: reduce verbosity of --populate

[Allan McRae]

On 19/06/12 22:38, Pierre Schmitz wrote:
> Am 19.06.2012 06:42, schrieb Allan McRae:
>> On 19/06/12 00:46, Pierre Schmitz wrote:
>>> -				"${GPG_PACMAN[@]}" --import-ownertrust "${KEYRING_IMPORT_DIR}/${keyring}-trusted"
>>> +				"${GPG_PACMAN[@]}" --import-ownertrust "${KEYRING_IMPORT_DIR}/${keyring}-trusted" 2>/dev/null
>>
>> Ugh...  I hate how mundane stuff is printed to stderr here.  Is there
>> anything that can possible go wrong during this step that would actually
>> require us to see output on stderr?
> 
> The problem here is that gpg outputs just everything to stderr here not
> just errors. And this output is not even that helpful. It would print
> something like "gpg: changing ownertrust from 2 to 4" five times.
> 
> I would say it's safe enough to suppress any output here. The only
> errors I can think of is that either your gnupg homedir is corrupt
> (which we would detect much earlier in the script or the ownertrust file
> includes garbage. Wrong data wont matter here; gpg does not complain if
> your set the trust level of a non-existent key here.
> 


I'm going to give this patch an tentative ack...    I do not like the
idea of hiding stderr at all, but it seems that the scope for an actual
error to be output here is very small and too much output is almost as
bad as no output.

Pulled to my working branch,
Allan