[pacman-dev] [PATCH] makepkg: fix log file names for arch=any packages

[Allan McRae]

On 21/06/12 00:31, Florian Pritz wrote:
> On 06/20/2012 05:28 AM, Allan McRae wrote:
>> This does not
>> handle split packages that have different architectures.
> 
> Split packages use pkgbase rather than pkgname[@] as the name for the
> logfile, so even if you override arch from within a package function my
> patch should work.
> 
> Could someone else take a look?
> 


On 21/06/12 00:31, Florian Pritz wrote:> On 06/20/2012 05:28 AM, Allan
McRae wrote:
>> This does not
>> handle split packages that have different architectures.
>
> Split packages use pkgbase rather than pkgname[@] as the name for the
> logfile, so even if you override arch from within a package function my
> patch should work.
>
> Could someone else take a look?
>


What should the log file names be for this PKGBUILD?

pkgname=('foo' 'bar')
pkgver=1
pkgrel=1
arch=('i686' 'x86_64')

package_foo() {
  :
}

package_bar() {
  arch=('any')
}


What about for this one?

pkgname=('foo' 'bar')
pkgver=1
pkgrel=1
arch=('any')

package_foo() {
  :
}

package_bar() {
  arch=('i686' 'x86_64')
}



Now...  I actually like the actual build arch listed in the log file
name.   If I have an "arch=any" package that fails only on a certain
architecture, it is handy to know what arch it was build on.  So I see
the current behaviour as a feature and not a bug.

Allan