[pacman-dev] [PATCH 06/11] makepkg: allow using GIT source URLs

Thomas Bächler thomas at archlinux.org
Wed Jun 27 05:49:35 EDT 2012


Am 27.06.2012 11:14, schrieb Allan McRae:
> On 27/06/12 18:54, Thomas Bächler wrote:
>> Am 27.06.2012 00:58, schrieb Allan McRae:
>>> +	if [[ ! -d "$startdir"/$folder && -d "$SRCDEST"/$folder ]]; then
>>> +		folder="$SRCDEST"/$folder
>>> +	else
>>> +		folder="$startdir"/$folder
>>> +	fi
>>
>> I don't understand this logic: Does this mean that you put the git clone
>> to $startdir/$folder by default? If $SRCDEST is set, I would always
>> expect it to go to $SRCDEST.
>>
> 
> Yeah, that was an oversight there - and probably completely broken.  But
> it is entirely fixed in patch 09/11.

Didn't see that, but yeah, seems to make more sense there.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.archlinux.org/pipermail/pacman-dev/attachments/20120627/459cd0ba/attachment.asc>


More information about the pacman-dev mailing list