[pacman-dev] [PATCH 0/6] fix some safety issues in makepkg

Allan McRae allan at archlinux.org
Fri Mar 9 02:59:03 EST 2012

With the upcoming makepkg-lobotomy (removing the error trap apart from
in the actual packaging steps), we need to add some more error checking
and be as safe as possible when potentially dealing with strange variable

Some of these are a bit unnecessary (e.g. using printf to output
variables that almost certainly cannot start with a "-n"), but there is
no harm in applying them globally.

Allan McRae (6):
  makepkg: the rhs in string comparisons should be quoted
  makepkg: use printf rather than echo to output variable
  makepkg: prevent issues with files starting with a hyphen
  makepkg: abort when failing to create BUILDDIR
  makepkg: quote removed filename as it can have spaces
  makepkg: safely change directories

 scripts/makepkg.sh.in |  147 ++++++++++++++++++++++++++-----------------------
 1 file changed, 79 insertions(+), 68 deletions(-)


More information about the pacman-dev mailing list