[pacman-dev] [PATCH 3/4] pacman-key: reduce verbosity of --populate

[Allan McRae]

On 25/03/12 22:10, Pierre Schmitz wrote:
> Do not bother the user with gpg's verbose output.
> 
> Signed-off-by: Pierre Schmitz <pierre at archlinux.de>
> ---
>  scripts/pacman-key.sh.in |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/pacman-key.sh.in b/scripts/pacman-key.sh.in
> index 46773ac..4c02d7d 100644
> --- a/scripts/pacman-key.sh.in
> +++ b/scripts/pacman-key.sh.in
> @@ -250,7 +250,7 @@ populate_keyring() {
>  	# Add keys from requested keyrings
>  	for keyring in "${KEYRINGIDS[@]}"; do
>  		msg "$(gettext "Appending keys from %s.gpg...")" "$keyring"
> -		"${GPG_PACMAN[@]}" --import "${KEYRING_IMPORT_DIR}/${keyring}.gpg"
> +		"${GPG_PACMAN[@]}" --import "${KEYRING_IMPORT_DIR}/${keyring}.gpg" 2>/dev/null

Is the output on stderr?  I am reluctant to remove real error output.

>  	done
>  
>  	# Read the trusted key IDs to an array. Because this is an ownertrust
> @@ -275,12 +275,12 @@ populate_keyring() {
>  		msg "$(gettext "Locally signing trusted keys in keyring...")"
>  		for key_id in "${!trusted_ids[@]}"; do
>  			msg2 "$(gettext "Locally signing key %s...")" "${key_id}"
> -			"${GPG_PACMAN[@]}" --quiet --batch --yes --lsign-key "${key_id}"
> +			"${GPG_PACMAN[@]}" --quiet --batch --yes --lsign-key "${key_id}" 2>/dev/null
>  		done
>  		msg "$(gettext "Importing owner trust values...")"
>  		for keyring in "${KEYRINGIDS[@]}"; do
>  			if [[ -f "${KEYRING_IMPORT_DIR}/${keyring}-trusted" ]]; then
> -				"${GPG_PACMAN[@]}" --import-ownertrust "${KEYRING_IMPORT_DIR}/${keyring}-trusted"
> +				"${GPG_PACMAN[@]}" --import-ownertrust "${KEYRING_IMPORT_DIR}/${keyring}-trusted" 2>/dev/null
>  			fi
>  		done
>  	fi