[pacman-dev] [PATCH 3/8] Add function to extract key id from signatures

[Allan McRae]

On 03/11/12 01:40, Dave Reisner wrote:
> On Sat, Nov 03, 2012 at 01:28:17AM +1000, Allan McRae wrote:
>> This does not support all possibilities of RFC4880, but it does
>> cover every key currently used in Arch Linux.
> 
> Hmmm, this function doesn't seem to distinguish between "not a key" and
> "not a supported key". Can we return more useful error codes, like
> -ENOSYS for unsupported, -EINVAL for not-a-signature packet...

Instead of doing this I have added ALPM_LOG_ERROR messages that output
why the key has failed. I think this is a more clear way to allow a user
to report and issue allowing us to follow up any failure in the future.

Allan