[pacman-dev] [PATCH] Use sentence case in makepkg

[Jason St. John]

On Mon, Nov 19, 2012 at 6:42 PM, Allan McRae <allan at archlinux.org> wrote:
> On 20/11/12 06:28, Jason St. John wrote:
>> From: "Jason St. John" <jstjohn at purdue.edu>
>>
>> Most of makepkg already uses sentence case. This cleans up the
>> last few stragglers.
>>
>> Signed-off-by: Jason St. John <jstjohn at purdue.edu>
>> ---
>>  scripts/makepkg.sh.in | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
>> index d387b7d..f4ee97d 100644
>> --- a/scripts/makepkg.sh.in
>> +++ b/scripts/makepkg.sh.in
>> @@ -645,7 +645,7 @@ download_svn() {
>>  }
>>
>>  download_sources() {
>> -     msg "$(gettext "Retrieving Sources...")"
>> +     msg "$(gettext "Retrieving sources...")"
>>
>>       local GET_VCS=1
>>       if [[ $1 == "fast" ]]; then
>> @@ -951,7 +951,7 @@ resolve_deps() {
>>               [[ -z $deplist ]] && return $R_DEPS_SATISFIED
>>       fi
>>
>> -     msg "$(gettext "Missing Dependencies:")"
>> +     msg "$(gettext "Missing dependencies:")"
>>       local dep
>>       for dep in $deplist; do
>>               msg2 "$dep"
>> @@ -1214,7 +1214,7 @@ check_source_integrity() {
>>  }
>>
>>  extract_sources() {
>> -     msg "$(gettext "Extracting Sources...")"
>> +     msg "$(gettext "Extracting sources...")"
>>       local netfile
>>       for netfile in "${source[@]}"; do
>>               local file=$(get_filename "$netfile")
>> @@ -1612,7 +1612,7 @@ find_libprovides() {
>>               esac
>>
>>               if (( missing )); then
>> -                     warning "$(gettext "Can not find library listed in %s: %s")" "'provides'" "$p"
>> +                     warning "$(gettext "Cannot find library listed in %s: %s")" "'provides'" "$p"
>>               fi
>>       done
>>
>> @@ -1633,7 +1633,7 @@ write_pkginfo() {
>>       if [[ -n $PACKAGER ]]; then
>>               local packager="$PACKAGER"
>>       else
>> -             local packager="Unknown Packager"
>> +             local packager="Unknown packager"
>
> This bit should stay as it is.  The patch is fine with that removed.
>
>>       fi
>>
>>       # btrfs's delayed allocation causes the stat buffers from the kernel to "lie"
>>
>
>

I just submitted another patch[1] that leaves "Unknown Packager" alone.

[1] https://mailman.archlinux.org/pipermail/pacman-dev/2012-November/016100.html

Jason