[pacman-dev] [PATCH 3/5] Removed quotes when using cd in build(), check() or package() too

[Dan McGee]

On Thu, Oct 25, 2012 at 8:20 AM, Alexander Rødseth <rodseth at gmail.com> wrote:
> Signed-off-by: Alexander Rødseth <rodseth at gmail.com>

How did this go when you placed a sample PKGBUILD in "/tmp/dir with
spaces/PKGBUILD" and ran it?

> ---
>  proto/PKGBUILD-split.proto | 8 ++++----
>  proto/PKGBUILD.proto       | 6 +++---
>  2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/proto/PKGBUILD-split.proto b/proto/PKGBUILD-split.proto
> index d400da7..ab31e71 100644
> --- a/proto/PKGBUILD-split.proto
> +++ b/proto/PKGBUILD-split.proto
> @@ -29,13 +29,13 @@ noextract=()
>  md5sums=() #generate with 'makepkg -g'
>
>  build() {
> -  cd "$srcdir/$pkgbase-$pkgver"
> +  cd $srcdir/$pkgbase-$pkgver
>    ./configure --prefix=/usr
>    make
>  }
>
>  check() {
> -  cd "$srcdir/$pkgname-$pkgver"
> +  cd $srcdir/$pkgname-$pkgver
>    make -k check
>  }
>
> @@ -59,7 +59,7 @@ package_pkg1() {
>    install=
>    changelog=
>
> -  cd "$srcdir/$pkgbase-$pkgver"
> +  cd $srcdir/$pkgbase-$pkgver
>    make DESTDIR="$pkgdir/" install-pkg1
>  }
>
> @@ -67,6 +67,6 @@ package_pkg2() {
>    # options and directives overrides
>    pkgdesc=""
>
> -  cd "$srcdir/$pkgbase-$pkgver"
> +  cd $srcdir/$pkgbase-$pkgver
>    make DESTDIR="$pkgdir/" install-pkg2
>  }
> diff --git a/proto/PKGBUILD.proto b/proto/PKGBUILD.proto
> index 1284cf5..5603e35 100644
> --- a/proto/PKGBUILD.proto
> +++ b/proto/PKGBUILD.proto
> @@ -29,18 +29,18 @@ noextract=()
>  md5sums=() #generate with 'makepkg -g'
>
>  build() {
> -  cd "$srcdir/$pkgname-$pkgver"
> +  cd $srcdir/$pkgname-$pkgver
>    ./configure --prefix=/usr
>    make
>  }
>
>  check() {
> -  cd "$srcdir/$pkgname-$pkgver"
> +  cd $srcdir/$pkgname-$pkgver
>    make -k check
>  }
>
>  package() {
> -  cd "$srcdir/$pkgname-$pkgver"
> +  cd $srcdir/$pkgname-$pkgver
>    make DESTDIR="$pkgdir/" install
>  }
>
> --
> 1.8.0
>
>