[pacman-dev] [PATCH 3/5] Removed quotes when using cd in build(), check() or package() too

[Dan McGee]

On Thu, Oct 25, 2012 at 8:44 AM, Alexander Rødseth <rodseth at gmail.com> wrote:
> Hi Dan,
>
> I was told that for official packages, spaces would never appear in
> $pkgdir, so quoting was not needed.

Mind naming that source? This concerns the directories that have
nothing to do with the package or pkgname itself, so I'm also not sure
how that applies here.

Also, Arch might have a standard of not naming packages with spaces,
but pacman itself has no problem with spaces in pkgnames, and I intend
to continue supporting that.

-Dan


diff --git a/test/pacman/tests/sync001.py b/test/pacman/tests/sync001.py
index 0f5fdcf..0ad46a5 100644
--- a/test/pacman/tests/sync001.py
+++ b/test/pacman/tests/sync001.py
@@ -1,13 +1,13 @@
 self.description = "Install a package from a sync db"

-sp = pmpkg("dummy")
+sp = pmpkg("dummy space")
 sp.files = ["bin/dummy",
             "usr/man/man1/dummy.1"]
 self.addpkg2db("sync", sp)

-self.args = "-S %s" % sp.name
+self.args = "-S '%s'" % sp.name

 self.addrule("PACMAN_RETCODE=0")
-self.addrule("PKG_EXIST=dummy")
+self.addrule("PKG_EXIST=%s" % sp.name)
 for f in sp.files:
 	self.addrule("FILE_EXIST=%s" % f)