[pacman-dev] [PATCH 4/7] makepkg: always use pkg/$pkgname as $pkgdir

Allan McRae allan at archlinux.org
Sun Sep 23 19:51:19 EDT 2012


On 24/09/12 01:55, Dave Reisner wrote:
>> +		pkgdir="$pkgdir/$pkgname"
>> > +		mkdir -p "$pkgdir"
>> > +		chmod a-s "$pkgdir"
> Can't we just use mkdir's -m flag here? It's specified by POSIX.
> 

Note this is used in multiple other places in makepkg. I seem to recall
we did not use the "-m" flag for some reason, but I can not remember
why.  Maybe Dan can shed some light here?

Anyway, I have just realized we only need it on the creation of $srcdir
and $startdir/pkg.  All directories created within them have no need for
it...

Allan


More information about the pacman-dev mailing list