[pacman-dev] [PATCH] updpkgsums: Add --clean to makepkg call

[Dave Reisner]

On Fri, Apr 5, 2013 at 8:42 PM, Sébastien Luttringer <seblu at seblu.net>wrote:

> On Sat, Apr 6, 2013 at 2:32 AM, Dave Reisner <d at falconindy.com> wrote:
>
> > On Sat, Apr 06, 2013 at 02:27:30AM +0200, Sébastien Luttringer wrote:
> > > Avoid makepkg to let src/ directory after updating the sums
> >
> > This has potential to incur unintended/unwanted side effects... I don't
> > think this should be the default. You could potentially look at
> > $BUILDDIR/src beforehand and only pass -c if the dir doesn't exist
> > beforehand, but I'm not sure we want to play that game.
> >
>
> I don't see what kind of unintented/unwanted side effects this can occur.
> Unless you speak about --asroot.
> Is the following code could avoid us of those effects ?
>
>  export BUILDDIR=$(mktemp --directory -t updpkgsums.XXXXX)
> makepkg --clean
>
>
Sorry for not being clear. My gripe is with the --clean flag. I'm strongly
disagree with the idea that we should assume the user doesn't want their
possibly large and already compiled build directory wiped out.