[pacman-dev] [PATCH] Give the frontend control over responses for print

Connor Behan connor.behan at gmail.com
Wed Apr 17 05:39:58 EDT 2013


On 16/04/13 09:55 PM, Allan McRae wrote:
> You provide details for many things that are not changed at all by the
> patch. Just detail what is changed (ALPM_QUESTION_INSTALL_IGNOREPKG). 

I wouldn't've written all that if I were just setting *response = 1 in
that case and returning. But I am setting *response = 0 in all other
cases because previous discussion was leaning towards the view that the
frontend should know what is going to happen no matter what the question is.

> If that is dead code, why propagate it? It should just be removed
> altogether (in another commit...). Which would leave a fairly
> redundant case statement. 

ALPM_QUESTION_IMPORT_KEY was dead code up until a few commits ago... but
yeah ALPM_QUESTION_LOCAL_NEWER is almost certainly not part of upcoming
plans.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 555 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.archlinux.org/pipermail/pacman-dev/attachments/20130417/fa70b0d3/attachment-0001.asc>


More information about the pacman-dev mailing list