[pacman-dev] [PATCH 2/7] pactest: treat unknown rules as failures

[Andrew Gregory]

Tests should only be skipped when they aren't relevant, not when the
test itself is bad.

Signed-off-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
---
 test/pacman/pmenv.py  | 5 ++---
 test/pacman/pmtest.py | 4 +---
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/test/pacman/pmenv.py b/test/pacman/pmenv.py
index 9a88262..5eaa473 100644
--- a/test/pacman/pmenv.py
+++ b/test/pacman/pmenv.py
@@ -110,9 +110,8 @@ def _printtest(t):
             else:
                 result = "[FAIL]"
             print result,
-            print "%s Rules: OK = %2u  FAIL = %2u  SKIP = %2u" \
-                    % (t.testname.ljust(34), success, fail, \
-                       rules - (success + fail))
+            print "%s Rules: OK = %2u  FAIL = %2u" \
+                    % (t.testname.ljust(34), success, fail)
             if fail != 0:
                 # print test description if test failed
                 print "      ", t.description
diff --git a/test/pacman/pmtest.py b/test/pacman/pmtest.py
index f5a9680..cea584d 100644
--- a/test/pacman/pmtest.py
+++ b/test/pacman/pmtest.py
@@ -266,11 +266,9 @@ def check(self):
             if success == 1:
                 msg = " OK "
                 self.result["success"] += 1
-            elif success == 0:
+            else:
                 msg = "FAIL"
                 self.result["fail"] += 1
-            else:
-                msg = "SKIP"
             print "\t[%s] %s" % (msg, i)
 
 # vim: set ts=4 sw=4 et:
-- 
1.8.3.4