[pacman-dev] [PATCH 4/4] makepkg: git: update existing sources in srcdir without removing them first.

[William Giokas]

On Tue, Dec 10, 2013 at 09:39:51AM +0100, Lukas Jirkovsky wrote:
> On Mon, Dec 9, 2013 at 10:10 PM, Dave Reisner <d at falconindy.com> wrote:
> > This groundbreaking idea has been proposed and rejected several times
> > already.
> >
> 
> Can you point me to where they were rejected? I have submitted the
> patches implementing this functionality in the past, but they were
> rejected because of technical problems, not because of the idea
> itself. This new patch series should fix all the issues that were
> present in my previous attempts. Also I remember that Allan set
> FS#35050 as due in 4.2.0 probably because I was working on it.

For the tl;dr:

Here's how we use git sources at the moment:

- Create bare clone (no checked out files)
- Clone the bare clone to build dir
- Build
- Possible cleanup

With a shallow clone the first two steps won't work at all. Look at the
manual page for git-clone(1):

  A shallow repository has a number of limitations (you cannot clone or
  fetch from it, nor push from nor into it)...

As you can see, we can't do the second step, and if we do the first step
with --depth=1, then it would essentially just give us a useless set of
files.

Thanks,
-- 
William Giokas | KaiSforza | http://kaictl.net/
GnuPG Key: 0x73CD09CF
Fingerprint: F73F 50EF BBE2 9846 8306  E6B8 6902 06D8 73CD 09CF
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://mailman.archlinux.org/pipermail/pacman-dev/attachments/20131210/6e7a7d0e/attachment-0001.asc>